amp-auto-ads: Ad placement configuration errors are user errors #9001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muxin
reviewed
Apr 27, 2017
| dev().error(TAG, 'amp-auto-ads config xhr failed: ' + reason); | ||
| return null; | ||
| user().error(TAG, 'amp-auto-ads config xhr failed: ' + reason); | ||
| throw reason; |
There was a problem hiding this comment.
Shall we keep the return null?
There was a problem hiding this comment.
This also cancels the entire promise queue if fetching/parsing of the configuration fails.
This is specifically to stop further processing, since we can't do anything without a config.
muxin
approved these changes
Apr 27, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…roject#9001) * Ad placement configuration errors are user errors * Fix type checks
KenneyE
pushed a commit
to spotxchange/amphtml
that referenced
this pull request
May 3, 2017
…roject#9001) * Ad placement configuration errors are user errors * Fix type checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all configuration errors into the user logs. The configurations aren't the AMP developers' responsibility, they're the ad server's.
This also cancels the entire promise queue if fetching/parsing of the configuration fails. There's no point in running any of the other code if it does.
Fixes #8997.
Fixes #8998.
Fixes #9023.
/to @tlong2